Re: [PATCH] submodule-parallel-fetch: make some file local symbols static

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Oct 1, 2015, 18:43 UTC
Message-ID: <560D7EE2.8060403@ramsayjones.plus.com>
In-Reply-To: <CAGZ79kZzLtK7+rHRG_misaa9=fWF+oyeryBa+kbD3F+EB=3LMQ@mail.gmail.com>

On 01/10/15 18:05, Stefan Beller wrote:

> On Thu, Oct 1, 2015 at 5:02 AM, Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>>

[snip]

Show 12 quoted lines

>> diff --git a/run-command.c b/run-command.c
>> index 341b23b..347d22e 100644
>> --- a/run-command.c
>> +++ b/run-command.c
>> @@ -865,7 +865,7 @@ int capture_command(struct child_process *cmd, struct strbuf *buf, size_t hint)
>>         return finish_command(cmd);
>>  }
>>
>> -struct parallel_processes {
>> +static struct parallel_processes {
> 
> will pickup in a reroll

Thanks

Show 20 quoted lines

> 
>>         void *data;
>>
>>         int max_processes;
>> diff --git a/submodule.c b/submodule.c
>> index bd6e208..638efb5 100644
>> --- a/submodule.c
>> +++ b/submodule.c
>> @@ -622,8 +622,8 @@ struct submodule_parallel_fetch {
>>  };
>>  #define SPF_INIT {0, ARGV_ARRAY_INIT, NULL, NULL, 0, 0, 0}
>>
>> -int get_next_submodule(void *data, struct child_process *cp,
>> -                      struct strbuf *err);
>> +static int get_next_submodule(void *data, struct child_process *cp,
>> +                             struct strbuf *err);
> 
> I thought I had this in yesterdays reroll (v6). Oh you're referring to
> the version
> from the 28th (I forgot to label them v5 I suppose).

Ah! I thought I'd seen it on the list. (I thought I was going crazy) ;-) Sorry, my fault. I just assumed that today's pu branch would have your latest patches - I didn't actually check that.

Note that the first hunk, above, is actually new (I hadn't noticed it before).

> 
> I will also get rid of the forward declaration.

Thanks!

ATB, Ramsay Jones

Show 16 quoted lines

> 
>>
>>  static int fetch_start_failure(void *data, struct child_process *cp,
>>                                struct strbuf *err)
>> @@ -682,8 +682,8 @@ out:
>>         return spf.result;
>>  }
>>
>> -int get_next_submodule(void *data, struct child_process *cp,
>> -                      struct strbuf *err)
>> +static int get_next_submodule(void *data, struct child_process *cp,
>> +                             struct strbuf *err)
>>  {
>>         int ret = 0;
>>         struct submodule_parallel_fetch *spf = data;
>> --