git/list[1] front-page[2] threads[3] people[4] search[5] about
 

t5561 failing after make PROFILE=GEN

From
Stephan Beyer <s-beyer@gmx.net>
Date
Sep 22, 2015, 23:21 UTC
Message-ID
<5601E283.2030507@gmx.net>
Hi,

I noticed that t5561 fails on my machine when compiling with "make PROFILE=GEN". Luckily, the reason seems to be the test only, not the tool it is testing.

I tracked it down that far that log_div() (defined in t/t5561-http-backend.sh but used in t/t556x_common) appends the given text to the access.log *before* the last GET log entry is written.

The test code does it right (as far as I managed to look over it), so this is maybe some odd flushing behavior of the web server? On the other hand, the problem only occurs with PROFILE=GEN but the web server should be independent of the Git compile-time configuration, right? Looks weird to me but I did not dig deep.

Replacing the log_div() implementation by "return 0" and removing the implied output solves the problem without breaking any test functionality. (For more clarity, the log_div() calls and definitions should be removed.) I refrained from sending this trivial patch because I am not sure if this is the right way to cope with the issue.

Best
  Stephan
Next: Jeff King
Message 1 of 9 in “t5561 failing after make PROFILE=GEN”
  1. Stephan BeyerSep 22, 2015
  2. Jeff KingSep 23, 2015
  3. t5561: get rid of racy appending to logfileStephan Beyer, Sep 24, 2015
  4. Jeff KingSep 24, 2015
  5. t5561: get rid of racy appending to logfileStephan Beyer, Sep 24, 2015
  6. Jeff KingSep 24, 2015
  7. Junio C HamanoSep 25, 2015
  8. Stephan BeyerSep 24, 2015
  9. Jeff KingSep 24, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.