git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Close config file handle if the entry to unset is not found

From
SSSven Strickroth <sven@cs-ware.de>
Date
Aug 14, 2015, 19:18 UTC
Message-ID
<55CE3F23.7040702@cs-ware.de>
Without this patch there might be open handle leaks.
Signed-off-by: Sup Yut Sum <ch3cooli@gmail.com>
Signed-off-by: Sven Strickroth <email@cs-ware.de>
---
 config.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/config.c b/config.c
index 9fd275f..89b49e3 100644
--- a/config.c
+++ b/config.c
@@ -2048,6 +2048,7 @@ int git_config_set_multivar_in_file(const char *config_filename,
 		if ((store.seen == 0 && value == NULL) ||
 				(store.seen > 1 && multi_replace == 0)) {
 			ret = CONFIG_NOTHING_SET;
+			close(in_fd);
 			goto out_free;
 		}
 
-- 
Best regards,
 Sven Strickroth
 PGP key id F5A9D4C4 @ any key-server
Next: Eric Sunshine
Message 1 of 10 in “Close config file handle if the entry to unset is not found”
  1. Close config file handle if the entry to unset is not foundSven Strickroth, Aug 14, 2015
  2. Eric SunshineAug 14, 2015
  3. Sven StrickrothAug 14, 2015
  4. Correctly close config file handle in case of errorSven Strickroth, Aug 14, 2015
  5. Eric SunshineAug 14, 2015
  6. Correctly close config file handle in case of errorSven Strickroth, Aug 14, 2015
  7. Eric SunshineAug 14, 2015
  8. Correctly close config file handle in case of errorSven Strickroth, Aug 14, 2015
  9. Eric SunshineAug 14, 2015
  10. Junio C HamanoAug 14, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.