Re: [PATCH 0/17] removing questionable uses of git_path
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Aug 10, 2015, 12:06 UTC
- Message-ID
- <55C893CF.4060103@alum.mit.edu>
- In-Reply-To
- <20150810092731.GA9027@sigill.intra.peff.net>
On 08/10/2015 11:27 AM, Jeff King wrote:
Show 20 quoted lines
> [...] The problem is that git_path uses a static buffer that gets overwritten > by subsequent calls. [...] > > [01/17]: cache.h: clarify documentation for git_path, et al > [02/17]: cache.h: complete set of git_path_submodule helpers > [03/17]: t5700: modernize style > [04/17]: add_to_alternates_file: don't add duplicate entries > [05/17]: remove hold_lock_file_for_append > [06/17]: prefer git_pathdup to git_path in some possibly-dangerous cases > [07/17]: prefer mkpathdup to mkpath in assignments > [08/17]: remote.c: drop extraneous local variable from migrate_file > [09/17]: refs.c: remove extra git_path calls from read_loose refs > [10/17]: path.c: drop git_path_submodule > [11/17]: refs.c: simplify strbufs in reflog setup and writing > [12/17]: refs.c: avoid repeated git_path calls in rename_tmp_log > [13/17]: refs.c: avoid git_path assignment in lock_ref_sha1_basic > [14/17]: refs.c: remove_empty_directories can take a strbuf > [15/17]: find_hook: keep our own static buffer > [16/17]: get_repo_path: refactor path-allocation > [17/17]: memoize common git-path "constant" files
I read through all of the patches (except for 03) and didn't see any problems. Thanks, Peff, for defusing some grenades :-)
Michael
-- Michael Haggerty mhagger@alum.mit.edu