Re: [PATCH] git-p4: fix faulty paths for case insensitive systems

From: Luke Diamand <luke@diamand.org>
Date: Aug 4, 2015, 22:06 UTC
Message-ID: <55C1374E.5060808@diamand.org>
In-Reply-To: <1438528517-5028-1-git-send-email-larsxschneider@gmail.com>

On 02/08/15 16:15, larsxschneider@gmail.com wrote:

Show 6 quoted lines

> From: Lars Schneider <larsxschneider@gmail.com>
>
> Hi,
>
> I want to propose this patch as it helped us to migrate a big source code base
> successfully from P4 to Git. I am sorry that I don't provide a test case, yet.

Case sensitivity is a pretty tricky area with p4 - it's very brave of you to have a go at fixing it!

> I would like to get advise on the patch and on the best strategy to provide a
> test. Do you only run git-p4 integration tests in "t/t98??-git-p4-*.sh"? If yes,
> which version of "start_p4d" should I use?

Only the t98* tests relate to git-p4 so if you just copy one of those it should do the right thing.

t9819-git-p4-case-folding.sh already has a few failing tests for this problem. I wrote it a while back just to illustrate the problem, so it might be of use to you, or you might need to start again.

Won't your change make importing much slower for people with this problem?

Also, I'm not sure you can use "core.ignorecase" to trigger this: the problem will arise if the *server* is ignoring case as well (which I think you can detect by querying the server).

I'm not trying to be negative - but this problem does have some annoying pitfalls! Let me know if you think I can help though.

Regards! Luke