git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 0/7] ref backend preamble

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Jul 21, 2015, 14:02 UTC
Message-ID
<55AE5103.7020907@alum.mit.edu>
In-Reply-To
<1436482260-28088-1-git-send-email-dturner@twopensource.com>
On 07/09/2015 03:50 PM, David Turner wrote:
Show 12 quoted lines
> The current state of the discussion on alternate ref backends is that
> we're going to continue to store pseudorefs (e.g. CHERRY_PICK_HEAD) as
> files in $GIT_DIR.  So this re-roll of the refs backend preamble
> doesn't do anything to pseudorefs.  It just does reflog stuff.
> 
> In addition, this version removes the over-aggressive die() on reflog
> update failure from v7.  It adds the REF_FORCE_CREATE_REFLOG flag, as
> Michael Haggerty suggested.  And it fixes commit message or two, as
> suggested.  I believe this addresses all comments I've seen on v7.
> 
> This addresses Johannes Sixt's concerns too, by removing the offending
> code.

I just reviewed the whole patch series. Aside from the minor points that I commented on, it all looks good to me.

Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
Previous: David Turner
Message 14 of 14 in “ref backend preamble”
  1. 0/7 ref backend preambleDavid Turner, Jul 9, 2015
  2. 1/7 refs.c: add err arguments to reflog functionsDavid Turner, Jul 9, 2015
  3. Michael HaggertyJul 21, 2015
  4. 2/7 refs: Break out check for reflog autocreationDavid Turner, Jul 9, 2015
  5. 3/7 refs: new public ref function: safe_create_reflogDavid Turner, Jul 9, 2015
  6. 4/7 git-reflog: add exists commandDavid Turner, Jul 9, 2015
  7. Michael HaggertyJul 21, 2015
  8. 5/7 refs: add REF_FORCE_CREATE_REFLOG flagDavid Turner, Jul 9, 2015
  9. 6/7 update-ref and tag: add --create-reflog argDavid Turner, Jul 9, 2015
  10. Michael HaggertyJul 21, 2015
  11. 7/7 git-stash: use update-ref --create-reflog instead of creating filesDavid Turner, Jul 9, 2015
  12. Philip OakleyJul 10, 2015
  13. David TurnerJul 10, 2015
  14. Michael HaggertyJul 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.