git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Fix sed usage in tests to work around broken xpg4/sed on Solaris

From
Johannes Sixt <j6t@kdbg.org>
Date
Jul 19, 2015, 08:40 UTC
Message-ID
<55AB6290.2090003@kdbg.org>
In-Reply-To
<fadc4ff7e755913a4c6076165556b56c@www.dscho.org>
Am 19.07.2015 um 09:37 schrieb Johannes Schindelin:
Show 12 quoted lines
> On 2015-07-19 08:54, Johannes Sixt wrote:
>> Am 18.07.2015 um 17:21 schrieb Ben Walton:
>>> -	sed -e s/CHANGE_ME/change_me/ <file >file+ &&
>>> -	mv -f file+ file &&
>>> +	perl -pi -e "s/CHANGE_ME/change_me/" file &&
>>
>> This is problematic. On Windows, perl -i fails when no backup file
>> extension is specified because perl attempts to replace a file that is
>> still open; that does not work on Windows.
>
> Let's qualify this a bit better: it actually works with the SDK of
> Git  for Windows 2.x.
Good to know!
> I really wonder why the previous ">file+ && mv -f file+ file" dance
> needs to be replaced?

The sed must be replaced because some versions on Solaris choke on the incomplete last line in the file.

-- Hannes
Previous: Johannes SchindelinNext: Junio C Hamano
Message 5 of 7 in “Fix sed usage in tests to work around broken xpg4/sed on Solaris”
  1. 2/2 Fix sed usage in tests to work around broken xpg4/sed on SolarisBen Walton, Jul 18, 2015
  2. Eric SunshineJul 19, 2015
  3. Johannes SixtJul 19, 2015
  4. Johannes SchindelinJul 19, 2015
  5. Johannes SixtJul 19, 2015
  6. Junio C HamanoJul 20, 2015
  7. Johannes SchindelinJul 22, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.