Re: [PATCH v6 5/7] refs: new public ref function: safe_create_reflog

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Jul 8, 2015, 11:04 UTC
Message-ID: <559D03AC.4060706@alum.mit.edu>
In-Reply-To: <1436311118.5521.16.camel@twopensource.com>

On 07/08/2015 01:18 AM, David Turner wrote:

Show 22 quoted lines

> On Mon, 2015-07-06 at 18:21 +0200, Michael Haggerty wrote:
> 
> <snip> changes applied; will re-roll.
> 
>>> +
>>> +int safe_create_reflog(const char *refname, struct strbuf *err, int force_create)
>>> +{
>>> +	int ret;
>>> +	struct strbuf sb = STRBUF_INIT;
>>> +
>>> +	ret = log_ref_setup(refname, &sb, err, force_create);
>>> +	strbuf_release(&sb);
>>> +	return ret;
>>> +}
>>> +
>>
>> Is it really necessary to have two functions, safe_create_reflog() and
>> log_ref_setup()? I don't see any of the callers doing anything special
>> with the sb_logfile argument from the latter, so maybe it could be
>> inlined into safe_create_reflog()? Maybe I'm overlooking something.
> 
> log_ref_write_1 does use the sb_logfile argument.

Thanks for the clarification. I *did* overlook something.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu