Re: slash in branch name
- From
- KK <horizn@wp.pl>
- Date
- Jun 17, 2015, 19:38 UTC
- Message-ID
- <5581CCD1.4010606@wp.pl>
- In-Reply-To
- <20150617192444.GD25304@peff.net>
On 17/06/2015 20:24, Jeff King wrote:
Show 39 quoted lines
> On Wed, Jun 17, 2015 at 08:16:10PM +0100, KK wrote: > >> remote: error: invalid key: hooks.denypush.branch.versions/4.3.2 >> remote: error: invalid key: hooks.allowmerge.versions/4.3.2 >> [...] > > Those are syntactically bogus config keys. Keys should be of the form > > section.subsection.key > > and only "subsection" can contain arbitrary bytes (and of course the > value can, too). The hooks running on the server are using git's config > system in ways that were not intended. It should rearrange its > organization of the data (I cannot comment much further without seeing > the hooks themselves). > >> My colleague did some research about that and it seems that this commit has >> stopped update hook working: >> >> commit b09c53a3e331211fc0154de8ebb271e48f8c7ee5 >> Author: Libor Pechacek <lpechacek@suse.cz> >> Date: Sun Jan 30 20:40:41 2011 +0100 >> >> Sanity-check config variable names >> [...] >> >> Could you please advise how to fix/revert this? > > I guess we could add a "--no-really-i-am-abusing-git-config" option to > git-config to let these pass, at least for lookups. I am not sure that > is a good idea, though. I think your hooks are fundamentally broken for > branches with odd characters (right now you are seeing complaints on the > lookup side, but I suspect that you could not write a > "hooks.denypush.branch.versions/4.3.2" entry if you wanted to, as git > would choke on reading the config file). > > -Peff > >
hooks were downloaded from: git://git.et.redhat.com/ovirt-server.git