Re: [PATCH 4/5] receive-pack: use bug() and BUG_if_bug()

From: Andrei Rybak <rybak.a.v@gmail.com>
Date: May 27, 2022, 22:53 UTC
Message-ID: <55585ede-0135-b996-08da-fc1919827981@gmail.com>
In-Reply-To: <patch-4.5-c590f4273c0-20220521T170939Z-avarab@gmail.com>

On 21/05/2022 19:14, Ævar Arnfjörð Bjarmason wrote:

> Amend code added in a6a84319686 (receive-pack.c: shorten the
> execute_commands loop over all commands, 2015-01-07) and amended to
> hard die in b6a4788586d (receive-pack.c: die instead of error in case
> of possible future bug, 2015-01-07) to the new bug() function instead.

A verb is missing after "to". "to use the new bug() function", perhaps?

Show 6 quoted lines

> 
> Let's also rename the warn_if_*() function that code is in to
> BUG_if_*(), its name became outdated in b6a4788586d.
> 
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.