Re: [PATCH v5 1/3] tree-walk: learn get_tree_entry_follow_symlinks

From: Johannes Sixt <j6t@kdbg.org>
Date: May 12, 2015, 17:29 UTC
Message-ID: <5552385D.1050303@kdbg.org>
In-Reply-To: <1431384645-17276-2-git-send-email-dturner@twopensource.com>

Am 12.05.2015 um 00:50 schrieb dturner@twopensource.com:

Show 13 quoted lines

> +		} else if (S_ISLNK(*mode)) {
> +			/* Follow a symlink */
> +			size_t link_len, len;
> +			char *contents, *contents_start;
> +			struct dir_state *parent;
> +			enum object_type type;
> +
> +			if (follows_remaining-- == 0)
> +				/* Too many symlinks followed */
> +				goto done;
> +
> +			contents = read_sha1_file(current_tree_sha1, &type,
> +						  &link_len);

In this line, I get:

tree-walk.c: In function 'get_tree_entry_follow_symlinks': tree-walk.c:637: warning: passing argument 3 of 'read_sha1_file' from incompatible pointer type cache.h:885: note: expected 'long unsigned int *' but argument is of type 'size_t *'

-- Hannes