Re: [PATCHv2] gitk: Show the current view's name in the window title.
On 15-04-07 11:51 AM, Marc Branchaud wrote:
Show 10 quoted lines
> If the current view is the "Command line" view, show the command line
> arguments instead of the view name.
>
> Signed-off-by: Marc Branchaud <marcnarc@xiplink.com>
> ---
>
> This is v2 of my previous "Show the command-line revs in the window title" RFC
> patch. (I'm having trouble accessing gmane, or I'd include a link here.)
>
> This version incorporates Paul's feedback (thanks!) and handles view properly.
Show 55 quoted lines
> M.
>
> gitk | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/gitk b/gitk
> index b859879..90419e3 100755
> --- a/gitk
> +++ b/gitk
> @@ -4034,6 +4034,19 @@ proc shellsplit {str} {
> return $l
> }
>
> +proc set_window_title {} {
> + global appname curview viewname vrevs
> + set rev [mc "All files"]
> + if {$curview ne 0} {
> + if {$viewname($curview) eq [mc "Command line"]} {
> + set rev [string map {"--gitk-symmetric-diff-marker" "--merge"} $vrevs($curview)]
> + } else {
> + set rev $viewname($curview)
> + }
> + }
> + wm title . "[reponame]: $rev - $appname"
> +}
> +
> # Code to implement multiple views
>
> proc newview {ishighlight} {
> @@ -4510,6 +4523,7 @@ proc showview {n} {
> } elseif {$numcommits == 0} {
> show_status [mc "No commits selected"]
> }
> + set_window_title
> }
>
> # Stuff relating to the highlighting facility
> @@ -6650,6 +6664,7 @@ proc show_status {msg} {
> global canv fgcolor
>
> clear_display
> + set_window_title
> $canv create text 3 3 -anchor nw -text $msg -font mainfont \
> -tags text -fill $fgcolor
> }
> @@ -12393,7 +12408,7 @@ catch {
> }
> # wait for the window to become visible
> tkwait visibility .
> -wm title . "[reponame] - $appname"
> +set_window_title
> update
> readrefs
>
> Marc Branchaud <marcnarc@xiplink.com>