git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Apr 2015, #04; Mon, 27)

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Apr 30, 2015, 06:55 UTC
Message-ID
<5541D1D0.8070407@alum.mit.edu>
In-Reply-To
<xmqqbni64kum.fsf@gitster.dls.corp.google.com>
On 04/30/2015 12:42 AM, Junio C Hamano wrote:
Show 33 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> Here are the topics that have been cooking.  Commits prefixed with
>> '-' are only in 'pu' (proposed updates) while commits prefixed with
>> '+' are in 'next'.
>> ...
> 
> There are a handful of topics that are almost there but not
> finished.  Could the topic owners and area submaintainers who are
> involved in them report their current status soonish, please, to
> help me decide to keep or discard them?
> [...]
>> * mh/numparse (2015-03-19) 14 commits
>>  - diff_opt_parse(): use convert_i() when handling --abbrev=<num>
>>  - diff_opt_parse(): use convert_i() when handling "-l<num>"
>>  - opt_arg(): simplify pointer handling
>>  - opt_arg(): report errors parsing option values
>>  - opt_arg(): use convert_i() in implementation
>>  - opt_arg(): val is always non-NULL
>>  - builtin_diff(): detect errors when parsing --unified argument
>>  - handle_revision_opt(): use convert_ui() when handling "--abbrev="
>>  - strtoul_ui(), strtol_i(): remove functions
>>  - handle_revision_opt(): use convert_i() when handling "-<digit>"
>>  - handle_revision_opt(): use skip_prefix() in many places
>>  - write_subdirectory(): use convert_ui() for parsing mode
>>  - cacheinfo_callback(): use convert_ui() when handling "--cacheinfo"
>>  - numparse: new module for parsing integral numbers
>>
>>  Many codepaths use unchecked use of strtol() and friends (or even
>>  worse, atoi()).  Introduce a set of wrappers that try to be more
>>  careful.
>>
>>  Waiting for a reroll ($gmane/266209).

Yes, I've started rerolling this series a bit less ambitiously; i.e., introduce the numparse API but in the first iteration avoid changing the behavior of the code that is doing the parsing. No ETA, I'm afraid.

Feel free to drop v1 from your repository unless you think it might be useful as a reminder or object for discussion or something.

Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
Previous: Junio C HamanoNext: Michael J Gruber
Message 9 of 13 in “What's cooking in git.git (Apr 2015, #04; Mon, 27)”
  1. Junio C HamanoApr 27, 2015
  2. Junio C HamanoApr 29, 2015
  3. Koosha KhajehmoogahiApr 29, 2015
  4. Junio C HamanoApr 30, 2015
  5. Paul TanApr 30, 2015
  6. Junio C HamanoApr 30, 2015
  7. Jeff KingApr 30, 2015
  8. Junio C HamanoApr 30, 2015
  9. Michael HaggertyApr 30, 2015
  10. Michael J GruberApr 30, 2015
  11. Michael HaggertyApr 30, 2015
  12. Duy NguyenApr 30, 2015
  13. Junio C HamanoApr 30, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.