Re: [PATCH v2] t0027: Add repoMIX and LF_nul

From: Torsten Bögershausen <tboegi@web.de>
Date: Apr 25, 2015, 21:43 UTC
Message-ID: <553C0A9B.7060407@web.de>
In-Reply-To: <xmqqegn817pr.fsf@gitster.dls.corp.google.com>

On 2015-04-25 18.41, Junio C Hamano wrote:

Show 18 quoted lines

> Torsten Bögershausen <tboegi@web.de> writes:
> 
>> "new safer autocrlf handling":
>>   Check if eols in a file are converted at commit, when the file has
>>   CR (or CLLF) in the repo (technically speaking in the index).
> 
> s/CLLF/CRLF/?  (no need to resend for this; I'll locally amend)
> 
>>   Add a test-file repoMIX with mixed line-endings.
>>   When converting LF->CRLF or CRLF->LF: check the warnings
>>
>> checkout_files():
>>   Checking out CRLF_nul and checking for eol coversion does not
>>   make much sense (CRLF will stay CRLF).
> 
> Hmph, would it still make sense to make sure that CRLF will stay CRLF
> so that future changes to break this expectation can be caught?  Not
> that such a breakage is likely...

Thanks for amending.

We have the file CRLF (and CRLFmixLF), where we check that CRLF stays CRLF and is not converted into CRLFLF.

The LF_nul is to test the "auto text detection": It should not be converted into CRLF_nul in "auto mode", but should be converted when declared as "text" in .gitattributes.