git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fast-import: add options to enable/disable case folding

From
Luke Diamand <luke@diamand.org>
Date
Apr 24, 2015, 09:42 UTC
Message-ID
<553A0FF6.6070700@diamand.org>
In-Reply-To
<20150418073611.GA13410@glandium.org>
On 18/04/15 08:36, Mike Hommey wrote:
Show 17 quoted lines
> On Fri, Apr 17, 2015 at 11:44:00AM -0700, Junio C Hamano wrote:
>> So perhaps we should rip the case folding out altogether instead?
>> The entry for the change in the Release Notes may say:
>>
>>   * "git fast-import" incorrectly case-folded the paths recorded in
>>     the history when core.ignorease is set (i.e. the repository's
>>     working tree is incapable of expressing paths that differ only in
>>     their cases); this old bug was reported in 2012 and was finally
>>     corrected.
>>
>> or something like that?
>
> Is anything else then git-p4 known to rely on case folding? If not, I
> guess that's a reasonable plan. We could even add an option to
> fast-import that would allow to turn case folding back on, and make
> git-p4 use it, so that its expectations are fulfilled. Although at some
> point, it could (should?) do case folding itself(?)

git-p4 has a single line of code that checks if core.ignorecase is turned on, and uses this to decide whether to skip files that are outside the depot being tracked and I *think* is not really related to fast-import.

I don't know to what extent though git-p4 relies on the current behaviour of git fast-import to fold case for it.

There's a 'p4 info' command which tells you what the server thinks it's doing:

$ p4 info | grep Case Case Handling: sensitive

I don't know how long that support has been present (it might not work on older servers that some people are still using).

It's also possible to force the server to be case-insensitive on the Linux version. That's useful, as it we could construct some test cases to see what we're likely to break without having to force people to install a case-insensitive OS in order to run the git regression tests.

Luke
Show 7 quoted lines
>
> Mike
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
Previous: Mike HommeyNext: Eric Sunshine
Message 11 of 12 in “fast-import should not care about core.ignorecase”
  1. Mike HommeyDec 9, 2014
  2. Mike HommeyDec 9, 2014
  3. Joshua JensenDec 9, 2014
  4. Jonathan NiederDec 9, 2014
  5. Joshua JensenDec 9, 2014
  6. Junio C HamanoDec 9, 2014
  7. fast-import: add options to enable/disable case foldingMike Hommey, Apr 17, 2015
  8. Torsten BögershausenApr 17, 2015
  9. Junio C HamanoApr 17, 2015
  10. Mike HommeyApr 18, 2015
  11. Luke DiamandApr 24, 2015
  12. Eric SunshineApr 17, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.