Re: [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()

From: Johannes Sixt <j6t@kdbg.org>
Date: Apr 15, 2015, 20:34 UTC
Message-ID: <552ECB61.3020502@kdbg.org>
In-Reply-To: <xmqq3841kz32.fsf@gitster.dls.corp.google.com>

Am 15.04.2015 um 20:48 schrieb Junio C Hamano:

Show 12 quoted lines

> The patch should do for now, but I suspect that it may give us a
> better abstraction to make the "is_foreground_fd(int fd)" or even
> "is_foreground(void)" the public API that would be implemented as
>
> 	int we_are_in_the_foreground(void)
>          {
> 		return getpgid(0) == tcgetpgrp(fileno(stderr));
> 	}
>
> in POSIX and Windows can implement entirely differently.
>
> Thoughts?

IMHO, this level of abstraction goes too far. It may be that I am not familiar with process groups, and I find the implementation of is_foreground_fd() in progress.c close to where it's used quite educating and enlightening. Hiding a similar implementation miles away in cache.h and/or compat/ would not pay off for me.

-- Hannes

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Git for Windows" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.