git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-gui: respect commit.gpgsign again

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Sep 9, 2016, 12:28 UTC
Message-ID
<550e7de5e08e53b5893e1ce021bffee468adfc9d.1473424091.git.johannes.schindelin@gmx.de>

As of v2.9.0, `git commit-tree` no longer heeds the `commit.gpgsign` config setting. This broke committing in Git GUI.

This fixes https://github.com/git-for-windows/git/issues/850
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
Published-As: https://github.com/dscho/git/releases/tag/git-gui-gpgsign-v1
Fetch-It-Via: git fetch https://github.com/dscho/git git-gui-gpgsign-v1
 git-gui/lib/commit.tcl | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/git-gui/lib/commit.tcl b/git-gui/lib/commit.tcl
index 864b687..01d2cc2 100644
--- a/git-gui/lib/commit.tcl
+++ b/git-gui/lib/commit.tcl
@@ -369,6 +369,9 @@ A rescan will be automatically started now.
 	# -- Create the commit.
 	#
 	set cmd [list commit-tree $tree_id]
+	if {[is_config_true commit.gpgsign]} {
+		lappend cmd -S
+	}
 	foreach p [concat $PARENT $MERGE_HEAD] {
 		lappend cmd -p $p
 	}
-- 
2.10.0.windows.1.10.g803177d

base-commit: 6ebdac1bab966b720d776aa43ca188fe378b1f4b
Next: Junio C Hamano
Message 1 of 5 in “git-gui: respect commit.gpgsign again”
  1. git-gui: respect commit.gpgsign againJohannes Schindelin, Sep 9, 2016
  2. Junio C HamanoSep 9, 2016
  3. Johannes SchindelinSep 10, 2016
  4. Junio C HamanoSep 11, 2016
  5. Johannes SchindelinSep 12, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.