Re: [PATCH v2] diff --shortstat --dirstat: remove duplicate output
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Mar 1, 2015, 10:25 UTC
- Message-ID
- <54F2E931.7020200@web.de>
- In-Reply-To
- <1425195546-15637-1-git-send-email-marten.kongstad@gmail.com>
On 2015-03-01 08.39, Mårten Kongstad wrote: [] index ed7e093..128f7bf 100755
Show 9 quoted lines
> --- a/t/t4047-diff-dirstat.sh > +++ b/t/t4047-diff-dirstat.sh > @@ -973,4 +973,15 @@ test_expect_success 'diff.dirstat=future_param,0,lines should warn, but still wo > test_i18ngrep -q "diff\\.dirstat" actual_error > ' > > +test_expect_success '--shortstat --dirstat should output only one dirstat' ' > + git diff --shortstat --dirstat=changes HEAD^..HEAD >actual_diff_shortstat_dirstat_changes && > + test $(grep -c " dst/copy/changed/$" actual_diff_shortstat_dirstat_changes) = 1 &&
How portable is the "grep -c" usage ? (I don't now it either, do we have other opinions ?), but the following seems to be more "Git-style":
test_expect_success '--shortstat --dirstat should output only one dirstat' ' git diff --shortstat --dirstat=changes HEAD^..HEAD >actual_diff_shortstat_dirstat_changes && grep " dst/copy/changed/$" actual_diff_shortstat_dirstat_changes >actual && test_line_count = 1 actual