Re: [PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git

From: Torsten Bögershausen <tboegi@web.de>
Date: Feb 22, 2015, 17:57 UTC
Message-ID: <54EA188E.9090601@web.de>
In-Reply-To: <54E8A9D0.30108@web.de>

(Sorry for the spam, a few things need correction already now, and forgot cc: Brian)

On 2015-02-21 16.52, Torsten Bögershausen wrote:

Show 6 quoted lines

> The ssh:// syntax was added in 2386d65822c91, it accepted
> ssh://user@2001:db8::1/repo.git, which is now legacy.
> 
> Over the years the parser was improved to support [] and port numbers,
> but the combination of ssh://user@[2001:db8::1]:222/repo.git did
> never work.

s/did never work/was never implemented/

> 
> The only only way to use a user name, a literall IPV6 address and a port

s/literall/literal/

Show 9 quoted lines

> number was ssh://[user@2001:db8::1]:222/repo.git
> 
> (Thanks to Christian Taube <lists@hcf.yourweb.de> for reporting this long
> standing issue)
> 
> New users would use ssh://user@[2001:db8::1]:222/repo.git,
> so change the parser to handle it correctly.
> 
> Support the old legacy URL's as well, to be backwards compatible,

s/URL's/URLs/