Re: Interested in helping open source friends on HP-UX?

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Feb 19, 2015, 10:33 UTC
Message-ID: <54E5BBDD.7040100@drmicha.warpmail.net>
In-Reply-To: <20150218185734.GB7257@peff.net>

Jeff King venit, vidit, dixit 18.02.2015 19:57:

Show 32 quoted lines

> On Wed, Feb 18, 2015 at 10:47:16AM -0800, Junio C Hamano wrote:
> 
>>> It seems like we could use
>>>
>>>   (cd src && tar cf - .) | (cd dst && tar xf -)
>>>
>>> here as a more portable alternative. I don't think we can rely on rsync
>>> being everywhere.
>>
>> Thanks; I wasn't even aware that we used rsync in our tests.  We
>> certainly do not want to rely on it.
> 
> I don't think we do.
> 
> Grepping for rsync in t/, it is mentioned in three places:
> 
>   1. In t1509, we use it, but that test script does not run unless you
>      set a bunch of environment variables to enable it.
> 
>   2. In a sample patch for t4100. Obviously this one doesn't execute. :)
> 
>   3. In t5500, to test "rsync:" protocol supported. This is behind a
>      check that we can run rsync at all (though it does not properly use
>      prereqs or use the normal "skip" procedure).
> 
>> Why not "cp -r src dst", though?
> 
> I was assuming that the "-P" in the original had some purpose. My "cp
> -r" does not seem to dereference symlinks, but maybe there is something
> I am missing.
> 
> -Peff

There's a symlink in sub that needs to be preserved.

I'm cooking up a mini-series covering tar/cp -P so far and hopefully the JP encodings later. Do I understand correctly that for Merijin's use case on HP-UX, we want

- as few extra tools (GNU...) as possible for the run time git
- may get a few more tools installed to run the test

I still don't have a clear picture of the iconv situation: Does your iconv library require OLD_ICONV to compile? Is there a reason you want to disable it?

Failing so many tests with NO_ICONV is certainly not ideal, but I'm not sure we should care to protect so many tests with a prerequisite.

Michael