Re: [PATCH 0/3] request-pull: do something if $3 is passed

From: Paolo Bonzini <bonzini@gnu.org>
Date: Feb 17, 2015, 20:34 UTC
Message-ID: <54E3A5E2.6060806@gnu.org>
In-Reply-To: <xmqqvbj01fbz.fsf@gitster.dls.corp.google.com>

On 17/02/2015 20:57, Junio C Hamano wrote:

Show 5 quoted lines

> Sorry, I was asking what you mean by "complains" (i.e. the exact
> error message).  I was and am guessing it is something like this: 
> 
>     warn: No match for commit 3188ab3... found at <url>
>     warn: Are you sure you pushed 'HEAD' there?

Yes, it is.

Show 9 quoted lines

> Asking to pull 'HEAD' may be often a wrong thing to do, and I
> wouldn't mind if this sequence:
> 
> 	git checkout kvm-next
>         git request-pull origin/master <url>
> 
> behaved the same way as
> 
>         git request-pull origin/master <url> kvm-next

FWIW, that would always be wrong for my scenario.

> But I do not know if the implicit HEAD should DWIM locally to this:
> 
>         git request-pull origin/master <url> for-linus

I guess only Linus could answer that, since he wrote 024d34cb0 and he knows the intent better than anyone else.

Paolo