git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFD 0/3] worktree.* config keys and submodule and multiple worktrees

From
Jens Lehmann <jens.lehmann@web.de>
Date
Feb 8, 2015, 17:36 UTC
Message-ID
<54D79EAB.6060301@web.de>
In-Reply-To
<1423401394-13675-1-git-send-email-pclouds@gmail.com>
Am 08.02.2015 um 05:16 schrieb Nguyễn Thái Ngọc Duy:
Show 10 quoted lines
> 1/3 is a more complete version of a patch I posted earlier [1]. It
> makes sure that worktree.* config keys are stored in a different place
> than $GIT_DIR/config. This allows us to work around the core.worktree
> issue in multiple worktree setting.
>
> I think 1/3 and 2/3 are fine. 3/3 is probably not. It's more of a
> proof of concept. The tests pass, but there's no migration path for
> existing submodules. Submodules modified by new Git will confuse old
> Git because the old ones do not understand worktree.path (the
> replacement for core.worktree)

Yeah, breaking every submodule cloned with v1.7.9 or newer is not the way to go. You'd still have to support the old configuration name for a very long time.

I wonder if it's worth all the hassle to invent new names. Wouldn't it be much better to just keep a list of per-worktree configuration value names and use that inside the config code to decide where to find them for multiple work trees. That would also work easily for stuff like EOL-config and would push the complexity in the config machinery and not onto the user.

Previous: Nguyễn Thái Ngọc DuyNext: Jens Lehmann
Message 5 of 22 in “worktree.* config keys and submodule and multiple worktrees”
  1. 0/3 worktree.* config keys and submodule and multiple worktreesNguyễn Thái Ngọc Duy, Feb 8, 2015
  2. 1/3 config.c: new config namespace worktree.* stored in $GIT_DIR/config.worktreeNguyễn Thái Ngọc Duy, Feb 8, 2015
  3. 2/3 setup: add worktree.path to shadow core.worktreeNguyễn Thái Ngọc Duy, Feb 8, 2015
  4. 3/3 submodule: use worktree.path instead of core.worktreeNguyễn Thái Ngọc Duy, Feb 8, 2015
  5. Jens LehmannFeb 8, 2015
  6. Jens LehmannFeb 8, 2015
  7. Duy NguyenFeb 9, 2015
  8. per-repository and per-worktree config variablesMax Kirillov, Mar 18, 2015
  9. Duy NguyenMar 24, 2015
  10. config.c: split some variables to $GIT_DIR/config.worktreeNguyễn Thái Ngọc Duy, Mar 26, 2015
  11. Max KirillovMar 26, 2015
  12. Duy NguyenMar 29, 2015
  13. Max KirillovMar 30, 2015
  14. config.c: split some variables to $GIT_DIR/config.worktreeNguyễn Thái Ngọc Duy, Mar 31, 2015
  15. Duy NguyenMar 31, 2015
  16. Max KirillovApr 1, 2015
  17. Duy NguyenApr 3, 2015
  18. Max KirillovApr 13, 2015
  19. Duy NguyenApr 18, 2015
  20. Max KirillovApr 20, 2015
  21. Duy NguyenApr 20, 2015
  22. Jens LehmannMar 25, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.