Re: [PATCH 2/2] Makes _do_open2 set _gitdir to actual path

From

Rémi Rampin <remirampin@gmail.com>

Date

Feb 3, 2015, 16:00 UTC

Message-ID

<54D0F0A9.3080607@gmail.com>

In-Reply-To

<CAFOYHZB_c3U9jpAq=jrGgMU+wMMf8w5D9iqLC9ccGC8S3hhXZg@mail.gmail.com>

2015-02-02 12:24 UTC-05:00, Remi Rampin <remirampin@gmail.com>:

>> -                       return [_is_git [file join [file dirname $path] $link_target]]
>> +                       set link_target_abs [file join [file dirname $path] $link_target]

2015-02-03 3:51 UTC-05:00, Chris Packham <judge.packham@gmail.com>:

> At this point link_target_abs is something like
> sub/../.git/modules/sub. It might be nice to normalize this with 'git
> rev-parse --git-dir' or even just (cd $link_target_abs && pwd). I'm
> not sure if tcl has anything built in that could do this kind of
> normalization.