Re: [PATCH] t1050-large: replace dd by test-genrandom
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Jan 13, 2015, 19:55 UTC
- Message-ID
- <54B5782A.2010003@kdbg.org>
- In-Reply-To
- <xmqqtwzucxwf.fsf@gitster.dls.corp.google.com>
Am 13.01.2015 um 19:56 schrieb Junio C Hamano:
Show 7 quoted lines
> Johannes Sixt <j6t@kdbg.org> writes: >> The new code does change some properties of the generated files: >> >> - They are a bit smaller. >> - They are not sparse anymore. >> - They do not compress well anymore. >> - The smaller of the four files is now a prefix of the larger.
Would you kindly strike the last bullet point when you apply the patch, because it is not true, as I just noticed:
>> + test-genrandom seed1 2000000 >large1 &&
...
>> + test-genrandom seed2 2500000 >huge &&
The seeds are different so that the files are completely dissimilar. This does not affect the rest of the analysis I gave in the commit message.
Thanks, -- Hannes