git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH V3 2/5] Help.c use OPT_BOOL and refactor logic

From
Philip Oakley <philipoakley@iee.org>
Date
Apr 3, 2013, 22:24 UTC
Message-ID
<548AC0AF83DA42EA8C39C268693606AD@PhilipOakley>
In-Reply-To
<7vhajo76xh.fsf@alter.siamese.dyndns.org>
Sent: Wednesday, April 03, 2013 2:13 AM
Show 9 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> You are creating a gap in the output so that you can add some more
>> stuff in later patches, which is fine, but I do not think we call
>> that kind of change a "refactor" ;-).
>>
>> The change looks fine.
> 
> I'll queue what I suggested on 'pu' for now.
It looks good. I'm happy with your suggestions as queued.
Acked-by: Philip Oakley <philipoakley@iee.org>

Longer term I'd like to be able to show all the guides as a double -gg option, but this is a great start.

Show 5 quoted lines
> 
> Thanks.
> 
> 
> -----
Previous: Junio C HamanoNext: Philip Oakley
Message 7 of 16 in “Git help option to list user guides”
  1. 0/5 Git help option to list user guidesPhilip Oakley, Apr 2, 2013
  2. 1/5 Show help: -a and -g option, and 'git help <concept>' usage.Philip Oakley, Apr 2, 2013
  3. Junio C HamanoApr 2, 2013
  4. 2/5 Help.c use OPT_BOOL and refactor logicPhilip Oakley, Apr 2, 2013
  5. Junio C HamanoApr 2, 2013
  6. Junio C HamanoApr 3, 2013
  7. Philip OakleyApr 3, 2013
  8. 3/5 Help.c add --guide optionPhilip Oakley, Apr 2, 2013
  9. 4/5 Help.c: add list_common_guides_help() functionPhilip Oakley, Apr 2, 2013
  10. Junio C HamanoApr 2, 2013
  11. Eric SunshineApr 3, 2013
  12. help: mark common_guides[] as translatableSimon Ruderich, Apr 12, 2013
  13. Philip OakleyApr 12, 2013
  14. 5/5 Help doc: Include --guide option descriptionPhilip Oakley, Apr 2, 2013
  15. Junio C HamanoApr 2, 2013
  16. Eric SunshineApr 3, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.