git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t0050-*.sh: mark the rename (case change) test as passing

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Nov 28, 2014, 16:57 UTC
Message-ID
<5478A96E.8030706@ramsay1.demon.co.uk>

Since commit baa37bff ("mv: allow renaming to fix case on case insensitive filesystems", 08-05-2014), the 'git mv' command has been able to rename a file, to one which differs only in case, on a case insensitive filesystem.

This results in the 'rename (case change)' test, which used to fail prior to this commit, to now (unexpectedly) pass. Mark this test as passing.

Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Junio,

I noticed this last week while testing on cygwin. I have only tested this on (64-bit) cygwin/ntfs, but I would assume that other case insensitive filesystems would be OK, since there have been no complaints about t6039-merge-ignorecase.sh not working.

Note that I didn't remove $test_case, despite having removed its last use in this test, in case there will be a future need. I'm not sure there will be a future need, of course, so if you would rather I got rid of it, just let me know.

ATB, Ramsay Jones

 t/t0050-filesystem.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh
index 6b3cedc..988c392 100755
--- a/t/t0050-filesystem.sh
+++ b/t/t0050-filesystem.sh
@@ -64,7 +64,7 @@ test_expect_success "setup case tests" '
 	git checkout -f master
 '
 
-$test_case 'rename (case change)' '
+test_expect_success 'rename (case change)' '
 	git mv camelcase CamelCase &&
 	git commit -m "rename"
 '
-- 
2.1.0
Next: Eric Sunshine
Message 1 of 2 in “t0050-*.sh: mark the rename (case change) test as passing”
  1. t0050-*.sh: mark the rename (case change) test as passingRamsay Jones, Nov 28, 2014
  2. Eric SunshineNov 28, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.