Re: [PATCH RFC] CYGWIN: avoid implicit declaration warning

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Nov 23, 2014, 23:15 UTC
Message-ID: <54726A8C.4040600@ramsay1.demon.co.uk>
In-Reply-To: <xmqqegstychq.fsf@gitster.dls.corp.google.com>

On 23/11/14 18:53, Junio C Hamano wrote:

Show 21 quoted lines

> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> 
>> On 23/11/14 14:16, Torsten Bögershausen wrote:
>>> gcc under cygwin reports several warnings like this:
>>>  warning: implicit declaration of function 'memmem'
>>>   [-Wimplicit-function-declaration]
>>> This has been observed under CYGWIN-32 with GCC 4.7.3 as well
>>> as CYGWIN-64 with gcc v4.8.3-5 x86-64
>>
>> Heh, thanks for looking into this. Your email came at a good time,
>> since I was just about to boot my old laptop into windows XP to
>> test my patch on 32-bit cygwin! (If I had not been watching the
>> F1 Grand Prix on TV, I would already have done so! ;-) ).
>>
>> It's been a while since I updated my 32-bit cygwin installation
>> (about 6 months) but I'm a little surprised you found this issue
>> with gcc 4.7.3 (I'm _almost_ tempted to boot that laptop anyway
>> just to see what versions of software it is running).
> 
> So you have an old installation to check how well the patched
> version is accepted by the old set of header files?

... I can, indeed, use this old installation to test this on 32-bit cygwin. sigh, I thought I had dodged that bullet! ;-)

[I can't do this tonight and I'm pretty busy tomorrow, so it may have to wait until tomorrow evening at the earliest. sorry about that. :( ]

This does not help much with 64-bit cygwin. They are effectively two different 'distributions'.

ATB, Ramsay Jones