git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t1410: fix breakage on case-insensitive filesystems

From
Johannes Sixt <j6t@kdbg.org>
Date
Nov 12, 2014, 20:20 UTC
Message-ID
<5463C106.5090803@kdbg.org>
In-Reply-To
<20141109015918.GA24736@peff.net>
Am 09.11.2014 um 02:59 schrieb Jeff King:
Show 25 quoted lines
>  test_expect_success 'stale dirs do not cause d/f conflicts (reflogs off)' '
> -	test_when_finished "git branch -d a || git branch -d a/b" &&
> +	test_when_finished "git branch -d one || git branch -d one/two" &&
>  
> -	git branch a/b master &&
> -	echo "a/b@{0} branch: Created from master" >expect &&
> -	git log -g --format="%gd %gs" a/b >actual &&
> +	git branch one/two master &&
> +	echo "one/two@{0} branch: Created from master" >expect &&
> +	git log -g --format="%gd %gs" one/two >actual &&
>  	test_cmp expect actual &&
> -	git branch -d a/b &&
> +	git branch -d one/two &&
>  
> -	# same as before, but we only create a reflog for "a" if
> +	# same as before, but we only create a reflog for "one" if
>  	# it already exists, which it does not
> -	git -c core.logallrefupdates=false branch a master &&
> +	git -c core.logallrefupdates=false branch one master &&
>  	: >expect &&
> -	git log -g --format="%gd %gs" a >actual &&
> +	git log -g --format="%gd %gs" one >actual &&
>  	test_cmp expect actual
>  '
>  
On Linux I observe

Deleted branch one/two (was b60a214). warning: unable to unlink .git/logs/refs/heads/one: Is a directory Deleted branch one (was b60a214). ok 15 - stale dirs do not cause d/f conflicts (reflogs off)

(notice the warning) but on Windows the test fails with

Deleted branch one/two (was b60a214). error: Unable to append to .git/logs/refs/heads/one: Permission denied fatal: Cannot update the ref 'refs/heads/one'. not ok 15 - stale dirs do not cause d/f conflicts (reflogs off)

On both systems, .git/logs/refs/heads/one exists as an empty directory after the test.

I haven't dug further (will have to wait a day or two, so if you have time or a hint where to look...)

-- Hannes
Previous: Jeff KingNext: Jeff King
Message 15 of 26 in “Test failure”
  1. Michael BlumeNov 8, 2014
  2. Jeff KingNov 9, 2014
  3. t1410: fix breakage on case-insensitive filesystemsJeff King, Nov 9, 2014
  4. Michael BlumeNov 9, 2014
  5. Junio C HamanoNov 9, 2014
  6. Jeff KingNov 10, 2014
  7. Junio C HamanoNov 10, 2014
  8. Jeff KingNov 10, 2014
  9. Torsten BögershausenNov 9, 2014
  10. Michael BlumeNov 9, 2014
  11. Torsten BögershausenNov 9, 2014
  12. Michael BlumeNov 10, 2014
  13. Junio C HamanoNov 10, 2014
  14. Jeff KingNov 10, 2014
  15. Johannes SixtNov 12, 2014
  16. Jeff KingNov 12, 2014
  17. Johannes SixtNov 13, 2014
  18. Jeff KingNov 13, 2014
  19. Junio C HamanoNov 13, 2014
  20. Johannes SixtNov 14, 2014
  21. Jeff KingNov 14, 2014
  22. Junio C HamanoNov 14, 2014
  23. Andreas SchwabNov 14, 2014
  24. Johannes SixtNov 15, 2014
  25. Windows: correct detection of EISDIR in mingw_open()Johannes Sixt, Nov 16, 2014
  26. Michael BlumeNov 9, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.