git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] revision: remove definition of unused 'add_object' function

From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date
Oct 18, 2014, 21:36 UTC
Message-ID
<5442DD4C.9050908@ramsay1.demon.co.uk>
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
Hi Jeff,

I noticed that your 'jk/prune-mtime' branch removes the last caller of the add_object() function; specifically commit 5f78a431a ("reachable: use traverse_commit_list instead of custom walk", 15-10-2014).

If you need to re-roll those patches, could you please squash this patch into the above commit. (unless you have plans to add some new callers, of course! ;-) ).

Thanks!

ATB, Ramsay Jones

 revision.c | 10 ----------
 revision.h |  5 -----
 2 files changed, 15 deletions(-)
diff --git a/revision.c b/revision.c
index 1316fe0..7bdf760 100644
--- a/revision.c
+++ b/revision.c
@@ -87,16 +87,6 @@ void show_object_with_name(FILE *out, struct object *obj,
 	fputc('\n', out);
 }
 
-void add_object(struct object *obj,
-		struct object_array *p,
-		struct name_path *path,
-		const char *name)
-{
-	char *pn = path_name(path, name);
-	add_object_array(obj, pn, p);
-	free(pn);
-}
-
 static void mark_blob_uninteresting(struct blob *blob)
 {
 	if (!blob)
diff --git a/revision.h b/revision.h
index 9ab6755..b90f907 100644
--- a/revision.h
+++ b/revision.h
@@ -282,11 +282,6 @@ char *path_name(const struct name_path *path, const char *name);
 extern void show_object_with_name(FILE *, struct object *,
 				  const struct name_path *, const char *);
 
-extern void add_object(struct object *obj,
-		       struct object_array *p,
-		       struct name_path *path,
-		       const char *name);
-
 extern void add_pending_object(struct rev_info *revs,
 			       struct object *obj, const char *name);
 extern void add_pending_sha1(struct rev_info *revs,
-- 
2.1.0
Next: Jeff King
Message 1 of 3 in “revision: remove definition of unused 'add_object' function”
  1. revision: remove definition of unused 'add_object' functionRamsay Jones, Oct 18, 2014
  2. Jeff KingOct 19, 2014
  3. Ramsay JonesOct 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.