git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v23 0/25] rs/ref-transaction ("Use ref transactions", part 3)

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Oct 16, 2014, 23:27 UTC
Message-ID
<54405457.1040500@alum.mit.edu>
In-Reply-To
<20141015004522.GD32245@google.com>
On 10/15/2014 02:45 AM, Jonathan Nieder wrote:
Show 23 quoted lines
> This series by Ronnie was last seen on-list at [1].  It includes some
> improvements to the ref-transaction API, improves handling of poorly
> named refs (which should make it easier to tighten the refname format
> checks in the future), and is a stepping stone toward later series
> that use the ref-transaction API more and make it support alternate
> backends (yay!).
> 
> The changes since (a merge of 'master' and) v22 are very minor and can
> be seen below[2].  The more important change is that it's rebased
> against current 'master'.
> 
> Review comments from Michael and Junio were very helpful in getting
> this in shape.  Thanks much to both.
> 
> The series can also be found at
> 
>   git://repo.or.cz/git/jrn.git tags/rs/ref-transaction
> 
> It is based against current 'master' (670a3c1d, 2014-10-14) and
> intended for 'next'.
> 
> Thoughts welcome, as always.  Improvements preferred in the form of
> patches on top of the series.

Thanks for the new version. I reviewed the previous version pretty carefully in Gerrit and was very happy with the overall series, though there were still some rough spots. It seems to be much more polished now.

Given that I will be traveling for the next two weeks I probably won't be able to do another thorough review in time. But I just scanned through patches 01 - 19 and didn't notice any problems. Unfortunately I have to stop there.

Cheers, Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
Previous: Junio C Hamano
Message 28 of 28 in “rs/ref-transaction ("Use ref transactions", part 3)”
  1. 0/25 rs/ref-transaction ("Use ref transactions", part 3)Jonathan Nieder, Oct 15, 2014
  2. 01/25 mv test: recreate mod/ directory instead of relying on stale copyJonathan Nieder, Oct 15, 2014
  3. 02/25 wrapper.c: remove/unlink_or_warn: simplify, treat ENOENT as successJonathan Nieder, Oct 15, 2014
  4. 03/25 refs.c: lock_ref_sha1_basic is used for all refsJonathan Nieder, Oct 15, 2014
  5. 04/25 wrapper.c: add a new function unlink_or_msgJonathan Nieder, Oct 15, 2014
  6. 05/25 refs.c: add an err argument to delete_ref_looseJonathan Nieder, Oct 15, 2014
  7. 06/25 refs.c: pass the ref log message to _create/delete/update instead of _commitJonathan Nieder, Oct 15, 2014
  8. 07/25 rename_ref: don't ask read_ref_full where the ref came fromJonathan Nieder, Oct 15, 2014
  9. 08/25 refs.c: refuse to lock badly named refs in lock_ref_sha1_basicJonathan Nieder, Oct 15, 2014
  10. 09/25 refs.c: call lock_ref_sha1_basic directly from commitJonathan Nieder, Oct 15, 2014
  11. 10/25 refs.c: pass a list of names to skip to is_refname_availableJonathan Nieder, Oct 15, 2014
  12. 11/25 refs.c: ref_transaction_commit: distinguish name conflicts from other errorsJonathan Nieder, Oct 15, 2014
  13. 12/25 fetch.c: change s_update_ref to use a ref transactionJonathan Nieder, Oct 15, 2014
  14. 13/25 refs.c: make write_ref_sha1 staticJonathan Nieder, Oct 15, 2014
  15. 14/25 refs.c: change resolve_ref_unsafe reading argument to be a flags fieldJonathan Nieder, Oct 15, 2014
  16. 15/25 reflog test: test interaction with detached HEADJonathan Nieder, Oct 15, 2014
  17. 16/25 branch -d: avoid repeated symref resolutionJonathan Nieder, Oct 15, 2014
  18. 17/25 branch -d: simplify by using RESOLVE_REF_READINGJonathan Nieder, Oct 15, 2014
  19. 18/25 packed-ref cache: forbid dot-components in refnamesJonathan Nieder, Oct 15, 2014
  20. 19/25 test: put tests for handling of bad ref names in one placeJonathan Nieder, Oct 15, 2014
  21. 20/25 refs.c: allow listing and deleting badly named refsJonathan Nieder, Oct 15, 2014
  22. 21/25 for-each-ref: skip and warn about broken ref namesJonathan Nieder, Oct 15, 2014
  23. 22/25 remote rm/prune: print a message when writing packed-refs failsJonathan Nieder, Oct 15, 2014
  24. 23/25 refs.c: do not permit err == NULLJonathan Nieder, Oct 15, 2014
  25. 24/25 lockfile: remove unable_to_lock_errorJonathan Nieder, Oct 15, 2014
  26. 25/25 ref_transaction_commit: bail out on failure to remove a refJonathan Nieder, Oct 15, 2014
  27. Junio C HamanoOct 15, 2014
  28. Michael HaggertyOct 16, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.