git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Do not make trace.c/getnanotime an inlined function

From
Johannes Sixt <j6t@kdbg.org>
Date
Sep 29, 2014, 20:40 UTC
Message-ID
<5429C3B5.5020401@kdbg.org>
In-Reply-To
<CAP30j14QGtHC7huU=3t4sJT_dZ3t9V=CBWyGyJW7EjT9H5ZK9w@mail.gmail.com>
Am 28.09.2014 um 22:42 schrieb Ben Walton:
Show 11 quoted lines
> On Sun, Sep 28, 2014 at 8:15 PM, Johannes Sixt <j6t@kdbg.org
> <mailto:j6t@kdbg.org>> wrote:
>     Am 28.09.2014 um 09:50 schrieb Ben Walton:
>     > -inline uint64_t getnanotime(void)
>     > +uint64_t getnanotime(void)
> 
>     But then the function could stay static, no?
> 
> 
> This function is used in several places outside of the translation unit
> so while it's possible, I think it's more work than it's worth...

I see. I didn't check myself, sorry. I assumed that due to the 'inline' the function would not have been available outside. Now your patch looks good.

Thanks, -- Hannes

Previous: Junio C Hamano
Message 7 of 7 in “Do not make trace.c/getnanotime an inlined function”
  1. Do not make trace.c/getnanotime an inlined functionBen Walton, Sep 28, 2014
  2. Johannes SixtSep 28, 2014
  3. Duy NguyenSep 29, 2014
  4. Junio C HamanoSep 29, 2014
  5. Duy NguyenSep 30, 2014
  6. Junio C HamanoSep 30, 2014
  7. Johannes SixtSep 29, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.