Re: [PATCH v3 2/2] headers: include dependent headers

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Sep 7, 2014, 11:01 UTC
Message-ID: <540C3AEC.7080908@ramsay1.demon.co.uk>
In-Reply-To: <540C350F.3080906@web.de>

On 07/09/14 11:35, René Scharfe wrote:

Show 20 quoted lines

> Am 07.09.2014 um 11:36 schrieb David Aguilar:
>> Add dependent headers so that including a header does not
>> require including additional headers.
>>
>> This makes it so that "gcc -c $header" succeeds for each header.
> 
>> diff --git a/cache.h b/cache.h
>> index 4d5b76c..8b827d7 100644
>> --- a/cache.h
>> +++ b/cache.h
>> @@ -1,7 +1,6 @@
>>   #ifndef CACHE_H
>>   #define CACHE_H
>>
>> -#include "git-compat-util.h"
>>   #include "strbuf.h"
>>   #include "hashmap.h"
>>   #include "advice.h"
> 
> Oh, that's a new change and worth mentioning in the commit message.

Hmm, does this not break git? Unless you also change each '.c' file which includes cache.h to also include git-compat-util.h first, then I suspect (if nothing else) file I/O may be broken. (see _FILE_OFFSET_BITS).

Also, see Documentation/CodingGuidelines (lines 331-333).

ATB, Ramsay Jones