Re: What's cooking in git.git (Sep 2014, #01; Tue, 2)

From: Johannes Sixt <j6t@kdbg.org>
Date: Sep 3, 2014, 06:27 UTC
Message-ID: <5406B4EF.3050301@kdbg.org>
In-Reply-To: <xmqqzjehy8vx.fsf@gitster.dls.corp.google.com>

Am 03.09.2014 00:06, schrieb Junio C Hamano:

Show 12 quoted lines

> * jt/timer-settime (2014-08-29) 9 commits
>  - use timer_settime() for new platforms
>  - autoconf: check for timer_settime()
>  - autoconf: check for struct itimerspec
>  - autoconf: check for struct sigevent
>  - autoconf: check for struct timespec
>  - autoconf: check for timer_t
>  - autoconf: check for setitimer()
>  - autoconf: check for struct itimerval
>  - git-compat-util.h: add missing semicolon after struct itimerval
> 
>  Need a rerolled one.

Yes. Please mark the MinGW build as not having timer_settime. Better yet, implement it in compat/mingw.c to replace its setitimer() implementation.

As a bug report, currently, I get

    CC progress.o
progress.c: In function 'set_progress_signal':
progress.c:66: error: 'CLOCK_MONOTONIC' undeclared (first use in this
function)

even though I have NO_TIMER_SETTIME set in my config.mak (but no other of new configuration options that this series introduces).

But IMHO, this topic goes in a wrong direction. "Avoid deprecated interfaces" is way overrated. It would be preferable (IMHO) to implement setitimer() in compat/ for systems that don't have it.

-- Hannes