Re: git v2.49.0 - gitk regression on Cygwin

From: Mark Levedahl <mlevedahl@gmail.com>
Date: Mar 29, 2025, 21:49 UTC
Message-ID: <53c31331-97ed-48be-8399-2701581b09a9@gmail.com>
In-Reply-To: <7b4149e1-44f8-44d4-89f8-647734f9e674@kdbg.org>

On 3/28/25 1:30 PM, Johannes Sixt wrote:

Show 6 quoted lines

> Indeed, it seems that this override is only needed on Windows. Dscho, is
> there a non-obvious reason that 'exec' and 'open' are overridden on all
> platforms?
>
> -- Hannes
>

(resending to avoid HTML ...)

Looking at git-gui's history, I see no deliberate decision to alter the native path search on any platform except Windows, just no effort ever to leave non-Windows platforms alone. The buggy Cygwin code is part of what I excised from git-gui in 2023 (commit 7145c654 on the git-gui tree).

  I'll plan to send a patch for gitk to revert non-windows platforms to 
native functions in a couple of days. This idea applies also to git-gui.

Mark