Re: [PATCH v2 1/3] Push the NATIVE_CRLF Makefile variable to C and added a test for native.

From: Torsten Bögershausen <tboegi@web.de>
Date: Aug 23, 2014, 06:22 UTC
Message-ID: <53F83321.1060906@web.de>
In-Reply-To: <xmqq61hknnjo.fsf@gitster.dls.corp.google.com>

On 2014-08-23 00.54, Junio C Hamano wrote:

Show 16 quoted lines

> Torsten Bögershausen <tboegi@web.de> writes:
> 
>> Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
>> incorrectly set on Mingw git. However, the Makefile variable is not
>> propagated to the C preprocessor and results in no change. This patch
>> pushes the definition to the C code and adds a test to validate that
>> when core.eol as native is crlf, we actually normalize text files to this
>> line ending convention when core.autocrlf is false.
>>
>> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
>> Signed-off-by: Stepan Kasal <kasal@ucw.cz>
>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>> ---
> 
> Who should I record as the author of this patch?
>

Sorry for missing this, here is what Mingw says:

commit 0caba2cacbb9d8e6a31783b45f1a13e52dec6ce8
Author: Pat Thoyts <patthoyts@users.sourceforge.net>
Date:   Mon Nov 26 00:24:00 2012 +0000

    Push the NATIVE_CRLF Makefile variable to C and added a test for native.
    
    Commit 95f31e9a correctly points out that the NATIVE_CRLF setting is
[]