git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFC] git-imap-send: use libcurl for implementation

From
Bernhard Reiter <ockham@raz.or.at>
Date
Aug 19, 2014, 11:14 UTC
Message-ID
<53F33183.80802@raz.or.at>
In-Reply-To
<20140817184252.GB2200@peff.net>
Am 2014-08-17 um 20:42 schrieb Jeff King:
Show 20 quoted lines
> [...]
> 
>>> I'm not sure I understand this comment. Even if SSL is not in use,
>>> wouldn't we be passing a regular pipe to curl, which would break?
>>
>> Yeah, we can't do that, and thus would have to keep the handwritten IMAP
>> implementation just for the tunnel case (allowing to drop only the
>> OpenSSL specific stuff), see my other email:
>> http://www.mail-archive.com/git@vger.kernel.org/msg56791.html (the
>> relevant part is pretty far down at the bottom).
> 
> I'd really love it if we could make this work with tunnels and
> eventually get rid of the hand-written imap code entirely. I agree with
> Jonathan that we probably need to keep it around a bit for people on
> older curl, but dropping it is a good goal in the long run. That code
> was forked from the isync project, but mangled enough that we could not
> take bug fixes from upstream. As not many people use imap-send, I
> suspect it is largely unmaintained and the source of many lurking
> bugs[1]. Replacing it with curl's maintained implementation is probably
> a good step.

I'll work on this as soon as I find some time, but as that will include changes to run-command.c (and possibly other files?), I'd like to cover that in a commit of its own. Do you guys think the current patch [1] is good enough for "official" submission already? If so, do I need some sort of official review? Documentation/SubmittingPatches says I'm only supposed to direct it to Junio after the list "reaches consensus", so I'm wondering how to get there... :-)

Bernhard
Previous: Jeff KingNext: Junio C Hamano
Message 6 of 7 in “git-imap-send: use libcurl for implementation”
  1. git-imap-send: use libcurl for implementationBernhard Reiter, Aug 12, 2014
  2. Jonathan NiederAug 13, 2014
  3. Jeff KingAug 17, 2014
  4. Bernhard ReiterAug 17, 2014
  5. Jeff KingAug 17, 2014
  6. Bernhard ReiterAug 19, 2014
  7. Junio C HamanoAug 19, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.