git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] fast-import.c: replace `git_config()` with `git_config_get_*()` family

From
Tanay Abhra <tanayabh@gmail.com>
Date
Aug 13, 2014, 12:11 UTC
Message-ID
<53EB55F7.9060508@gmail.com>
In-Reply-To
<vpqppg4vdii.fsf@anie.imag.fr>
Show 8 quoted lines
>>  		if (pack_idx_opts.version > 2)
>> -			die("bad pack.indexversion=%"PRIu32,
>> -			    pack_idx_opts.version);
>> -		return 0;
>> +			die("bad pack.indexversion=%"PRIu32, pack_idx_opts.version);
> 
> One more opportunity for git_die_config()?
>

Yup, I had thought of changing that and above to git_die_config(), but didn't do it, will send a revised patch.

> Not that it's terribly important, but I think it's good that your
> refactoring also brings a few end-users benefits. It will help you show

I have been rewriting callers and the law of diminishing returns kicked in. I had rewritten some other call sites but I didn't see them bringing any benefits (cleaner control flow, less lines, bugs eliminated), so I left them out.

> off when you tell your friends what you did this summer (not "I did
> useless code churn" ;-) ), and helps everybody see the benefits of your
> GSoC ;-).
>
Previous: Matthieu MoyNext: Tanay Abhra
Message 11 of 19 in “fast-import.c: replace `git_config()` with `git_config_get_*()` family”
  1. 1/4 fast-import.c: replace `git_config()` with `git_config_get_*()` familyTanay Abhra, Aug 13, 2014
  2. 2/4 ll-merge.c: refactor `read_merge_config()` to use `git_config_string()`Tanay Abhra, Aug 13, 2014
  3. Matthieu MoyAug 13, 2014
  4. 2/4 ll-merge.c: refactor `read_merge_config()` to use `git_config_string()`Tanay Abhra, Aug 13, 2014
  5. Matthieu MoyAug 13, 2014
  6. Junio C HamanoAug 13, 2014
  7. 3/4 merge-recursive.c: replace `git_config()` with `git_config_get_int()`Tanay Abhra, Aug 13, 2014
  8. Matthieu MoyAug 13, 2014
  9. 4/4 builtin/apply.c: replace `git_config()` with `git_config_get_string_const()`Tanay Abhra, Aug 13, 2014
  10. Matthieu MoyAug 13, 2014
  11. Tanay AbhraAug 13, 2014
  12. 1/5 fast-import.c: replace `git_config()` with `git_config_get_*()` familyTanay Abhra, Aug 13, 2014
  13. Matthieu MoyAug 13, 2014
  14. 1/2 git_default_config() rewritten using the config-set APITanay Abhra, Aug 13, 2014
  15. 2/2 use the new git_default_config()Tanay Abhra, Aug 13, 2014
  16. Matthieu MoyAug 13, 2014
  17. Junio C HamanoAug 13, 2014
  18. Matthieu MoyAug 13, 2014
  19. Junio C HamanoAug 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.