git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Release notes grammatical fixes.

From
Marc Branchaud <marcnarc@xiplink.com>
Date
Aug 5, 2014, 21:57 UTC
Message-ID
<53E1533F.7020601@xiplink.com>
In-Reply-To
<xmqq8un2pyk3.fsf@gitster.dls.corp.google.com>
On 14-08-05 02:43 PM, Junio C Hamano wrote:
Show 33 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> Marc Branchaud <marcnarc@xiplink.com> writes:
>> ...
>>> @@ -87,22 +87,20 @@ UI, Workflows & Features
>>>   * "git mergetool" learned to drive the vimdiff3 backend.
>>>  
>>>   * mergetool.prompt used to default to 'true', always asking "do you
>>> -   really want to run the tool on this path?".  Among the two
>>> -   purposes this prompt serves, ignore the use case to confirm that
>>> -   the user wants to view particular path with the named tool, and
>>> -   redefine the meaning of the prompt only to confirm the choice of
>>> -   the tool made by the autodetection (for those who configured the
>>> -   tool explicitly, the prompt shown for the latter purpose is
>>> -   simply annoying).
>>> -
>>> -   Strictly speaking, this is a backward incompatible change and the
>>> +   really want to run the tool on this path?".  The default has been
>>> +   changed to 'false'.  However, the prompt will still appear if
>>> +   mergetool used its autodetection system to guess which tool to use.
>>> +   Users who explicitly specify or configure a tool will no longer see
>>> +   the prompt by default.
>>> +
>>> +   Strictly speaking, this is a backward incompatible change and
>>>     users need to explicitly set the variable to 'true' if they want
>>> -   to resurrect the now-ignored use case.
>>> +   to resurrect the old behaviour.
>>
>> I however think you are losing information here.  It is unclear in
>> the rewritten one why you would ever want the "old" behaviour, i.e.
>> what you may be missing by following along with this change.
> 
> Perhaps this on top of yoru patch?
Yes, I think that's good, thanks.
		M.
Show 17 quoted lines
>  Documentation/RelNotes/2.1.0.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/RelNotes/2.1.0.txt b/Documentation/RelNotes/2.1.0.txt
> index 4fd153e..1b16b12 100644
> --- a/Documentation/RelNotes/2.1.0.txt
> +++ b/Documentation/RelNotes/2.1.0.txt
> @@ -95,7 +95,7 @@ UI, Workflows & Features
>  
>     Strictly speaking, this is a backward incompatible change and
>     users need to explicitly set the variable to 'true' if they want
> -   to resurrect the old behaviour.
> +   to be prompted to confirm running the tool on each path.
>  
>   * "git replace" learned the "--edit" subcommand to create a
>     replacement by editing an existing object.
> 
Previous: Junio C HamanoNext: Marc Branchaud
Message 7 of 9 in “[ANNOUNCE] Git v2.1.0-rc1”
  1. Junio C HamanoAug 4, 2014
  2. Ramsay JonesAug 4, 2014
  3. Junio C HamanoAug 5, 2014
  4. Release notes grammatical fixes.Marc Branchaud, Aug 5, 2014
  5. Junio C HamanoAug 5, 2014
  6. Junio C HamanoAug 5, 2014
  7. Marc BranchaudAug 5, 2014
  8. Marc BranchaudAug 5, 2014
  9. Junio C HamanoAug 5, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.