Re: [PATCH 2/3] wrapper: add xgetcwd()

From: René Scharfe <l.s.r@web.de>
Date: Jul 20, 2014, 15:22 UTC
Message-ID: <53CBDEC1.7010800@web.de>
In-Reply-To: <CACsJy8BUaAkO8_fjGCtVDyoSKkBQ+VKJLtjN_HZfV7XHOnS_yA@mail.gmail.com>

Am 20.07.2014 14:35, schrieb Duy Nguyen:

Show 9 quoted lines

> On Sun, Jul 20, 2014 at 6:21 PM, René Scharfe <l.s.r@web.de> wrote:
>> +char *xgetcwd(void)
>> +{
>> +       struct strbuf sb = STRBUF_INIT;
>> +       if (strbuf_add_cwd(&sb))
>> +               die_errno("unable to get current working directory");
>
> Wrap the string with _() to make it translatable? I can't see why any
> script would want to grep this string..

Sure, good idea.

>
>> +       return strbuf_detach(&sb, NULL);
>> +}

Thank you for the review, René