Re: [PATCH v1 1/3] dir.c: coding style fix

From: Karsten Blees <karsten.blees@gmail.com>
Date: Jul 15, 2014, 18:57 UTC
Message-ID: <53C579B4.2050506@gmail.com>
In-Reply-To: <xmqq4myjy3ms.fsf@gitster.dls.corp.google.com>

Am 15.07.2014 00:30, schrieb Junio C Hamano:

Show 14 quoted lines

> Karsten Blees <karsten.blees@gmail.com> writes:
> 
>> From: =?UTF-8?q?Nguy=E1=BB=85n=20Th=C3=A1i=20Ng=E1=BB=8Dc=20Duy?=
>>  <pclouds@gmail.com>
>>
>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
>> Signed-off-by: Karsten Blees <blees@dcon.de>
>> ---
> 
> Thanks for forwarding.   I'll fix-up the Yikes (see how these two
> lines show the same name in a very different way), but how did you
> produce the above?  Is there some fix we need in the toolchain that
> produces patch e-mails?
>

Hmmm...I simply thought that this is how its supposed to work. Mail headers can only contain US-ASCII, so the RFC 2047 Q-encoded-word generated by git-format-patch looked good to me.

It seems git-mailinfo doesn't handle line breaks in header lines in the mail body. I.e. if you remove the LF in the 'From:' line, everything is fine, despite the Q-encoding.

Now, 'git-format-patch --from' seems to work around the problem, but only for the 'From:' line. AFAICT there's no such option for 'Subject:', e.g. if you want to paste a patch after a scissors line, you're on your own (see the example in the git-format-patch(1) discussion section, with 'Subject:' both Q-encoded and line-wrapped).

Perhaps it should be clarified that git-format-patch output is not suitable for pasting into mail clients? Or it should print headers in plain text and let git-send-email handle the conversions?