git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v8 15/17] wt-status: simplify performance measurement by using getnanotime()

From
Karsten Blees <karsten.blees@gmail.com>
Date
Jul 12, 2014, 00:07 UTC
Message-ID
<53C07C48.2000004@gmail.com>
In-Reply-To
<53C079C5.8090503@gmail.com>

Calculating duration from a single uint64_t is simpler than from a struct timeval. Change performance measurement for 'advice.statusuoption' from gettimeofday() to getnanotime().

Also initialize t_begin to prevent uninitialized variable warning.
Signed-off-by: Karsten Blees <blees@dcon.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 wt-status.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/wt-status.c b/wt-status.c
index 318a191..dfdc018 100644
--- a/wt-status.c
+++ b/wt-status.c
@@ -574,14 +574,11 @@ static void wt_status_collect_untracked(struct wt_status *s)
 {
 	int i;
 	struct dir_struct dir;
-	struct timeval t_begin;
+	uint64_t t_begin = getnanotime();
 
 	if (!s->show_untracked_files)
 		return;
 
-	if (advice_status_u_option)
-		gettimeofday(&t_begin, NULL);
-
 	memset(&dir, 0, sizeof(dir));
 	if (s->show_untracked_files != SHOW_ALL_UNTRACKED_FILES)
 		dir.flags |=
@@ -612,13 +609,8 @@ static void wt_status_collect_untracked(struct wt_status *s)
 	free(dir.ignored);
 	clear_directory(&dir);
 
-	if (advice_status_u_option) {
-		struct timeval t_end;
-		gettimeofday(&t_end, NULL);
-		s->untracked_in_ms =
-			(uint64_t)t_end.tv_sec * 1000 + t_end.tv_usec / 1000 -
-			((uint64_t)t_begin.tv_sec * 1000 + t_begin.tv_usec / 1000);
-	}
+	if (advice_status_u_option)
+		s->untracked_in_ms = (getnanotime() - t_begin) / 1000000;
 }
 
 void wt_status_collect(struct wt_status *s)
-- 
2.0.0.406.g2e9ef9b

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Karsten BleesNext: Karsten Blees
Message 16 of 18 in “add performance tracing facility”
  1. 00/17 add performance tracing facilityKarsten Blees, Jul 11, 2014
  2. 01/17 trace: move trace declarations from cache.h to new trace.hKarsten Blees, Jul 11, 2014
  3. 02/17 trace: consistently name the format parameterKarsten Blees, Jul 11, 2014
  4. 03/17 trace: remove redundant printf format attributeKarsten Blees, Jul 11, 2014
  5. 04/17 trace: improve trace performanceKarsten Blees, Jul 12, 2014
  6. 05/17 Documentation/git.txt: improve documentation of 'GIT_TRACE*' variablesKarsten Blees, Jul 12, 2014
  7. 06/17 sha1_file: change GIT_TRACE_PACK_ACCESS logging to use trace APIKarsten Blees, Jul 12, 2014
  8. 07/17 trace: add infrastructure to augment trace output with additional infoKarsten Blees, Jul 12, 2014
  9. 08/17 trace: disable additional trace output for unit testsKarsten Blees, Jul 12, 2014
  10. 09/17 trace: add current timestamp to all trace outputKarsten Blees, Jul 12, 2014
  11. 10/17 trace: move code around, in preparation to file:line outputKarsten Blees, Jul 12, 2014
  12. 11/17 trace: add 'file:line' to all trace outputKarsten Blees, Jul 12, 2014
  13. 12/17 trace: add high resolution timer function to debug performance issuesKarsten Blees, Jul 12, 2014
  14. 13/17 trace: add trace_performance facility to debug performance issuesKarsten Blees, Jul 12, 2014
  15. 14/17 git: add performance tracing for git's main() function to debug scriptsKarsten Blees, Jul 12, 2014
  16. 15/17 wt-status: simplify performance measurement by using getnanotime()Karsten Blees, Jul 12, 2014
  17. 16/17 progress: simplify performance measurement by using getnanotime()Karsten Blees, Jul 12, 2014
  18. 17/17 api-trace.txt: add trace API documentationKarsten Blees, Jul 12, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.