Re: What's cooking in git.git (Jan 2016, #04; Wed, 20)
- From
Lars Schneider <larsxschneider@gmail.com>
- Date
- Jan 27, 2016, 08:46 UTC
- Message-ID
- <53B46FC1-7E34-49F1-9955-AE87E27519F5@gmail.com>
- In-Reply-To
- <xmqqwpqw9cdk.fsf@gitster.mtv.corp.google.com>
On 26 Jan 2016, at 23:58, Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
> Lars Schneider <larsxschneider@gmail.com> writes: > >> Hi Junio, >> >> Did you miss the topic "submodule: extend die message on failed >> checkout with depth argument" or do you not agree with it >> ($gmane/282779)? Stefan Beller reviewed the commits ($gmane/283666 >> and $gmane/283851). > > No, these three are still in my inbox. > > Quite honestly, "test to demonstrate breakage" alone is not all that > interesting to me unless I get a firm impression that somebody is > (or will soon be) working on fixing the breakage--which would make > it worth keeping track of it in my tree, to allow the eventual fix > to be more easily verified and protected from getting broken again. > Also "these look good to me" without much explanation is not much of > a review, and such a comment on a "demonstrate breakage" did not add > to the sense of urgency to the issue, either. > > That was why it has been sitting near the bottom of the pile.
OK, I get your point. I got the impression that Stefan is on to a fix ($gmane/281260). Looks like he is not and I need to learn more about Git to tackle fixes of this scope. Would it be an option for you to just drop patch 1/3 from this series and look at the remaining ones? 2/3 fixes an "&& chain issue" ($gmane/282776) and 3/3 prints a explanatory user warning instead of an incomprehensible error ($gmane/282777).
Thanks, Lars