Re: [PATCH v4] git-am: add option to extract email Message-Id: tag into commit log
- From
- Avi Kivity <avi@cloudius-systems.com>
- Date
- Jul 2, 2014, 16:15 UTC
- Message-ID
- <53B43021.9090506@cloudius-systems.com>
- In-Reply-To
- <53B41F28.8040205@web.de>
On 07/02/2014 06:03 PM, Torsten Bögershausen wrote:
Show 15 quoted lines
>> @@ -565,6 +568,7 @@ Use \"git am --abort\" to remove it.")" >> echo " $git_apply_opt" >"$dotest/apply-opt" >> echo "$threeway" >"$dotest/threeway" >> echo "$sign" >"$dotest/sign" >> + echo "$message_id" >"$dotest/message-id" >> echo "$utf8" >"$dotest/utf8" >> echo "$keep" >"$dotest/keep" >> echo "$scissors" >"$dotest/scissors" >> @@ -651,6 +655,10 @@ then >> else >> SIGNOFF= >> fi >> +if test "$(cat "$dotest/message-id")" = t > Does the usage of '"' inside of '"' look good, or can we write like this: > if test $(cat "$dotest/message-id") = t
With your change, it will fail if the file is missing or empty.
Complex shell scripts cannot be made to look good. If that's a requirement then the script should be rewritten in a reasonable language.