git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] First part of Unicode console support for msysgit

From
Karsten Blees <karsten.blees@gmail.com>
Date
Jun 6, 2014, 17:44 UTC
Message-ID
<5391FE01.9040501@gmail.com>
In-Reply-To
<1402062173-9602-1-git-send-email-kasal@ucw.cz>
Am 06.06.2014 15:42, schrieb Stepan Kasal:
> Hello,
> 
> this is first part of the unicode support pathes from msysgit.
> 
Nicely done, thanks!
I think its important to reiterate that these patches were written several years apart, so there are some inconsistencies and back-and-forth changes (e.g. [5/5] fixes line break errors introduced in [3/5]). I'm OK with merging this as is, if there are no objections from the list, simply because it represents the battle tested history we have in Git for Windows.
The only real complaint I have is that I'm missing [6/5] "Win32: fix broken pipe detection" [1], which leaves this series in a slightly broken state (terminating the pager will not terminate the calling git process).
Nitpicking follows...
Show 5 quoted lines
> The first three patches originate in Jun 2010, though some fixups from 2012
> have been squashed in.
> The fourth one is just a trivial prerequisite for
> the last one, that was written in Jan 2012, with a fixup from Mar 2012.
>

The dates are missing from the patches. It would also have been nice to name (or link to) the patches you sqashed.

Show 5 quoted lines
> Regards,
> 	Stepan
> 
> Karsten Blees (5):
>   Support Unicode console output on Windows
This introduces WriteConsoleW, so you could have squashed half of "Win32: fix segfault in WriteConsoleW when debugging in gdb" [2] (second  half in [5/5]).
>   Detect console streams more reliably on Windows
>   Warn if the Windows console font doesn't support Unicode
I think this one includes "MSVC: fix winansi.c compile errors " [3] and "Unicode console: fix font warning on Vista and Win7" [4] (which is partly reverted by [5/5], which also fixes the formatting).
>   Win32: move main macro to a function
Note: this one was submitted seperately on May 29 and May 1 (can't find it in the gmane archive, though).
Show 7 quoted lines
>   Win32: Thread-safe windows console output
> 
>  compat/mingw.c   |  24 ++-
>  compat/mingw.h   |  24 +--
>  compat/winansi.c | 446 ++++++++++++++++++++++++++++++++++++++++---------------
>  3 files changed, 356 insertions(+), 138 deletions(-)
>

[1] https://github.com/msysgit/git/commit/67934f93 [2] https://github.com/msysgit/git/commit/cd0792af [3] https://github.com/msysgit/git/commit/3abcb04d [4] https://github.com/msysgit/git/commit/981aa538

-- 
-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

--- 
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Previous: Karsten BleesNext: Stepan Kasal
Message 11 of 22 in “First part of Unicode console support for msysgit”
  1. 0/5 First part of Unicode console support for msysgitStepan Kasal, Jun 6, 2014
  2. 1/5 Support Unicode console output on WindowsStepan Kasal, Jun 6, 2014
  3. 2/5 Detect console streams more reliably on WindowsStepan Kasal, Jun 6, 2014
  4. 3/5 Warn if the Windows console font doesn't support UnicodeStepan Kasal, Jun 6, 2014
  5. Peter KreftingJun 6, 2014
  6. Stepan KasalJun 7, 2014
  7. 4/5 Win32: move main macro to a functionStepan Kasal, Jun 6, 2014
  8. 5/5 Win32: Thread-safe windows console outputStepan Kasal, Jun 6, 2014
  9. Peter KreftingJun 6, 2014
  10. Karsten BleesJun 6, 2014
  11. Karsten BleesJun 6, 2014
  12. Stepan KasalJun 6, 2014
  13. 0/6 First part of Unicode console support for msysgitStepan Kasal, Jun 7, 2014
  14. 1/6 Support Unicode console output on WindowsStepan Kasal, Jun 7, 2014
  15. 2/6 Detect console streams more reliably on WindowsStepan Kasal, Jun 7, 2014
  16. 3/6 Warn if the Windows console font doesn't support UnicodeStepan Kasal, Jun 7, 2014
  17. 4/6 Win32: add Unicode conversion functionsStepan Kasal, Jun 7, 2014
  18. 5/6 Win32: Thread-safe windows console outputStepan Kasal, Jun 7, 2014
  19. Johannes SixtJun 13, 2014
  20. 7/6 Win32: reliably detect console pipe handlesKarsten Blees, Jun 13, 2014
  21. 6/6 Win32: fix broken pipe detectionStepan Kasal, Jun 7, 2014
  22. Stepan KasalJun 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.