git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct

From
Torsten Bögershausen <tboegi@web.de>
Date
May 22, 2014, 13:13 UTC
Message-ID
<537DF7F2.8000401@web.de>
In-Reply-To
<1400762896-24324-1-git-send-email-gitter.spiros@gmail.com>
On 2014-05-22 14.48, Elia Pinto wrote:
> Found by check-non-portable-shell.pl
Thanks for picking this up
> -export TEST_DIRECTORY=$(pwd)/../../../t
> +TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTORY

Minor remark: Both commands should go on their own line, like this:

TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTORY

And, unrelated to this patch, there seem to be a lot of && missing in git-remote-testgit.sh. But this should be a seperate patch, I think.

Previous: Elia PintoNext: David Kastrup
Message 2 of 7 in “Get rid of the non portable shell export VAR=VALUE costruct”
  1. Get rid of the non portable shell export VAR=VALUE costructElia Pinto, May 22, 2014
  2. Torsten BögershausenMay 22, 2014
  3. David KastrupMay 22, 2014
  4. Johannes SixtMay 22, 2014
  5. David KastrupMay 22, 2014
  6. Elia PintoMay 22, 2014
  7. Junio C HamanoMay 22, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.