Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- May 22, 2014, 13:13 UTC
- Message-ID
- <537DF7F2.8000401@web.de>
- In-Reply-To
- <1400762896-24324-1-git-send-email-gitter.spiros@gmail.com>
On 2014-05-22 14.48, Elia Pinto wrote:
> Found by check-non-portable-shell.pl
Thanks for picking this up
> -export TEST_DIRECTORY=$(pwd)/../../../t > +TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTORY
Minor remark: Both commands should go on their own line, like this:
TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTORY
And, unrelated to this patch, there seem to be a lot of && missing in git-remote-testgit.sh. But this should be a seperate patch, I think.