Re: [BUG] git-gui regression in 2.0rcX within submodule

From: Chris Packham <judge.packham@gmail.com>
Date: May 13, 2014, 08:30 UTC
Message-ID: <5371D840.2020208@gmail.com>
In-Reply-To: <20140512234518.GB5529@home.lan>

Hi,

On 13/05/14 11:45, Yann Dirson wrote:

Show 37 quoted lines

> In 2.0rc2, git-gui is unable to work inside submodules, where 1.9.2
> did not show such a problem:
> 
> 
> yann@home:~$ cd /tmp/
> yann@home:tmp$ mkdir foo
> yann@home:tmp$ cd foo/
> yann@home:foo$ git init
> Initialized empty Git repository in /tmp/foo/.git/
> yann@home:foo (master)$ git submodule add git://git.debian.org/git/collab-maint/tulip.git debian
> Cloning into 'debian'...
> remote: Counting objects: 317, done.
> remote: Compressing objects: 100% (199/199), done.
> remote: Total 317 (delta 184), reused 166 (delta 95)
> Receiving objects: 100% (317/317), 73.81 KiB | 0 bytes/s, done.
> Resolving deltas: 100% (184/184), done.
> Checking connectivity... done.
> yann@home:foo (master)$ git status 
> On branch master
> 
> Initial commit
> 
> Changes to be committed:
>   (use "git rm --cached <file>..." to unstage)
> 
>         new file:   .gitmodules
>         new file:   debian
> 
> yann@home:foo (master)$ (cd debian/ && git gui)
> [errors out after showing the following error dialog]
> 
> | No working directory ../../../debian:
> | 
> | couldn't change working directory
> | to "../../../debian": no such file or
> | directory
>

I've already reported the same issue[1] and have posted a possible solution[2] although I haven't seen any feedback from Pat or anyone else.

Show 5 quoted lines

> 
> strace shows the failing chdir call is from git-gui itself, after
> getcwd() told him that it is in the dir that is indeed the workdir
> already.
>

--

[1] - http://article.gmane.org/gmane.comp.version-control.git/247511 [2] - http://article.gmane.org/gmane.comp.version-control.git/247564