Re: [PATCH v1 1/2] Remove 'git archimport'

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 9, 2014, 15:15 UTC
Message-ID: <536cf11632a85_ce316372ec85@nysa.notmuch>
In-Reply-To: <20140509145453.GA18197@sigill.intra.peff.net>

Jeff King wrote:

Show 17 quoted lines

> On Fri, May 09, 2014 at 04:20:40AM -0500, Felipe Contreras wrote:
> 
> > Eric Wong wrote:
> > > Felipe Contreras <felipe.contreras@gmail.com> wrote:
> > > > As a minimal token that anybody might possibly be using it, I would like
> > > > to see it work at least once. Since you said you have arch repos, can
> > > > you confirm that it does something?
> > > 
> > > Those repos are in offline/offsite storage and I do not have time to
> > > retrieve them.
> > 
> > Then we have no reason to believe they still work, and therefore, no
> > reason to believe anybody is using this.
> 
> Do you have any reason to believe they do NOT work? If not, and they are
> not causing any problems, then what is the benefit to getting rid of
> them?

Ask Junio. He is the one arguing that foreign tools should live in their own repository out-of-tree.

Show 13 quoted lines

> > > I've forgotten how to use tla to get a public repo, even.
> 
> I haven't used tla in quite a long time, but:
> 
>   tla register-archive http://www.atai.org/archarchives/atai@atai.org--public/
>   tla my-default-archive atai@atai.org--public
>   mkdir repo
>   cd repo
>   git archimport atai@atai.org--public
> 
> seemed to work (that archive is straight off the tla homepage's
> instructions). Looks like the commit messages could use some cleanup,
> but certainly it's better than nothing.

All right, I guess that' something, but I get:

  Use of each() on hash after insertion without resetting hash iterator
  results in undefined behavior, Perl interpreter: 0x1fec010 at
  /usr/lib/git-core/git-archimport line 129.

And a ton of:

  WARNING: no rule found for checking signatures from atai@atai.org--public

    Consider creating ~/.arch-params/signing/atai@atai.org--public.check
    or ~/.arch-params/signing/=default.check

I'll leave it running and see how it goes.

Still, if it's part of the core, it should have tests.

-- 
Felipe Contreras