git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH] git-completion.zsh: do not clobber complete()

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Apr 30, 2014, 10:02 UTC
Message-ID
<5360ca37ef906_47db12fd31035@nysa.notmuch>
In-Reply-To
<5360911d8fb6e_597a125b30828@nysa.notmuch>
Felipe Contreras wrote:
Show 8 quoted lines
> Mark Lodato wrote:
> > Previously, git-completion.zsh redefined complete() to make
> > __git_complete() a no-op. This broke zsh's built-in bash completion
> > compatibility layer (bashcompinit), which defines its own complete().
> 
> How exactly? I'm testing this and I don't see any problems. I run
> 'type -f _complete' and I get bashcompinit's complete, and the internal
> _complete() function is used only by the _git completion.

Ah, it's complete(), not _complete(). I see the problem and I'll propose a similar patch.

-- 
Felipe Contreras
Previous: Felipe Contreras
Message 3 of 3 in “git-completion.zsh: do not clobber complete()”
  1. git-completion.zsh: do not clobber complete()Mark Lodato, Feb 14, 2014
  2. Felipe ContrerasApr 30, 2014
  3. Felipe ContrerasApr 30, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.