git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] test-lib: Document short options in t/README

From
Ilya Bobyr <ilya.bobyr@gmail.com>
Date
Apr 30, 2014, 09:38 UTC
Message-ID
<5360C4B1.10701@gmail.com>
In-Reply-To
<xmqqr44nzyx6.fsf@gitster.dls.corp.google.com>
On 4/23/2014 11:24 AM, Junio C Hamano wrote:
Show 47 quoted lines
> Ilya Bobyr <ilya.bobyr@gmail.com> writes:
>> Most arguments that could be provided to a test have short forms.
>> Unless documented, the only way to learn them is to read the code.
>>
>> Signed-off-by: Ilya Bobyr <ilya.bobyr@gmail.com>
>> ---
>>  t/README |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/t/README b/t/README
>> index caeeb9d..6b93aca 100644
>> --- a/t/README
>> +++ b/t/README
>> @@ -71,7 +71,7 @@ You can pass --verbose (or -v), --debug (or -d), and --immediate
>>  (or -i) command line argument to the test, or by setting GIT_TEST_OPTS
>>  appropriately before running "make".
>>  
>> ---verbose::
>> +-v,--verbose::
>>  	This makes the test more verbose.  Specifically, the
>>  	command being run and their output if any are also
>>  	output.
> I was debating myself if the result should look more like this:
>
> 	-v::
> 	--verbose::
> 		This makes the test more verbose.  Specifically, the
> 		command being run and their output if any are also
> 		output.
>
> As a straight text file, your version is certainly a lot easier to
> read, but at the same time, the entire file is written in more or
> less AsciiDoc format (the list of prerequisites and the list of
> harness library functions need to be converted to the "item::" form
> for the text to format well, though) and I've seen some efforts by
> others to run text files in Documentation/ that were originally
> meant to be consumed as straight text thru AsciiDoc, so the latter
> form might be a small step for futureproofing.
>
> My conclusion at this point is that the original is good for the
> current need of the project; if somebody wants to include this file
> from somewhere in Documentation/technical, a conversion to use
> multiple "item1::<newline>item2::<newline>description" headers can
> be done by that person as part of the "make it fully AsciiDoc"
> effort.
>
> Thanks.

I've changed it. It is a trivial change and it does not seem to be that bad in plain text form either.

I do not know the AsciiDoc conventions as have not read its spec. If there are any other conventions I am breaking - let me know. I will read the spec if I will be contributing more to the documentation.

P.S.  Sorry it takes me this long to reply %)
Previous: Junio C HamanoNext: Ilya Bobyr
Message 4 of 17 in “Better control of the tests run by a test suite”
  1. Better control of the tests run by a test suiteIlya Bobyr, Apr 22, 2014
  2. 1/3 test-lib: Document short options in t/READMEIlya Bobyr, Apr 22, 2014
  3. Junio C HamanoApr 23, 2014
  4. Ilya BobyrApr 30, 2014
  5. 2/3 test-lib: tests skipped by GIT_SKIP_TESTS say soIlya Bobyr, Apr 22, 2014
  6. 3/3 test-lib: '--run' to run only specific testsIlya Bobyr, Apr 22, 2014
  7. Junio C HamanoApr 23, 2014
  8. Ilya BobyrApr 30, 2014
  9. Junio C HamanoApr 30, 2014
  10. Eric SunshineApr 23, 2014
  11. Ilya BobyrApr 30, 2014
  12. Better control of the tests run by a test suiteIlya Bobyr, Apr 30, 2014
  13. 1/3 test-lib: Document short options in t/READMEIlya Bobyr, Apr 30, 2014
  14. 2/3 test-lib: tests skipped by GIT_SKIP_TESTS say soIlya Bobyr, Apr 30, 2014
  15. 3/3 test-lib: '--run' to run only specific testsIlya Bobyr, Apr 30, 2014
  16. Junio C HamanoMay 6, 2014
  17. Junio C HamanoMay 6, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.