Re: [PATCH v7 03/12] revert/cherry-pick: add --quiet option

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 24, 2014, 23:33 UTC
Message-ID: <53599f34e416f_523614ed2ec21@nysa.notmuch>
In-Reply-To: <CALkWK0nETYdWpTYrNGE+au-b=jAXKy3FX6YOGo5s=v_UbnYtPA@mail.gmail.com>

Ramkumar Ramachandra wrote:

Show 15 quoted lines

> Felipe Contreras wrote:
> > @@ -635,9 +637,10 @@ static int do_pick_commit(struct commit *commit, struct replay_opts *opts)
> >         }
> >
> >         if (opts->skip_empty && is_index_unchanged() == 1) {
> > -               warning(_("skipping %s... %s"),
> > -                       find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
> > -                       msg.subject);
> > +               if (!opts->quiet)
> > +                       warning(_("skipping %s... %s"),
> > +                               find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV),
> > +                               msg.subject);
> 
> Personally, I don't see much value in inventing a new option for
> suppressing one message.

It's not one message; it's two messages from cherry-pick itself, and all the messages from `git commit`. Didn't we alread discuss this?

-- 
Felipe Contreras